[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-awt-dev
Subject:    <AWT Dev> [7u6] Review request for 7142091: [macosx] RFE: Refactoring of peer initialization/disposi
From:       artem.ananiev () oracle ! com (Artem Ananiev)
Date:       2012-06-26 13:18:39
Message-ID: 4FE9B6AF.4070809 () oracle ! com
[Download RAW message or body]


Still looks fine.

Thanks,

Artem

On 6/26/2012 3:49 PM, Sergey Bylokhov wrote:
> Hi Everyone,
> Please review the fix.
>
> Notes from the bug and comments:
> 1. setVisible() should be called at the end of the peers initialization.
> We can move super.initialize() to the end of the peers initializations.
> Initialize() was split to initialize() and initializeImpl(). In the
> initialize() we call initializeImpl and then we call to setVisible().
> initializeImpl overridden in subclasses.
>
> 2. Invokelater in the initialization/disposing is a tricky.
> Removed.
>
> 3. replaceSurfacedata() should be moved outside of
> LWWindowPeer.setVisible()
> Done. Also duplicate code was extracted to setVisible() method which
> call setVisibleImpl().
>
> 4. Backbuffer in replaceSurfacedata() should be initialized by clearRect
> instead of fillrect(composite is important).
> Done. related to composite.
>
> 5. During lwwindowpeer initialization we call two similar methods
> nativeSetNSWindowAlpha() and setAlphaValue().
> nativeSetNSWindowAlpha() removed from CPlatformWindow.java.
>
>
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142091
> Webrev can be found at: http://cr.openjdk.java.net/~serb/7142091/webrev.01/
>
> Also note that CR 7177173 depends from this one.
>
> --
> Best regards, Sergey.
>

[prev in list] [next in list] [prev in thread] [next in thread]