[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Integrated: 8289770: Remove Windows version macro from ShellFolder2.cpp
From:       Alexey Ivanov <aivanov () openjdk ! org>
Date:       2024-04-23 12:58:17
Message-ID: qTIMTGGn33-jMO4Z3qtekiSxxx00mUpHELOUchWnxbE=.0ef68a8f-2b8d-4eb2-a7b0-78fd73fe169e () github ! com
[Download RAW message or body]

On Thu, 11 Apr 2024 09:33:09 GMT, Alexey Ivanov <aivanov@openjdk.org> wrote:

> This clean-up PR removes unused Windows version macro from `ShellFolder2.cpp`.
> 
> `IS_WINVISTA` was not used at all.
> 
> `IS_WINXP` guarded support for icons with alpha channel. It is now safe to assume \
> Java runs on a Windows version later than Windows XP. Java launchers specify 6.0 as \
> the minimum OS version which corresponds to Windows Vista.

This pull request has now been integrated.

Changeset: 3d5eeac3
Author:    Alexey Ivanov <aivanov@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3d5eeac3a38ece4a23ea6da2dfe5939d64e81cea
                
Stats:     18 lines in 1 file changed: 0 ins; 13 del; 5 mod

8289770: Remove Windows version macro from ShellFolder2.cpp

Reviewed-by: jwaters, tr, serb

-------------

PR: https://git.openjdk.org/jdk/pull/18736


[prev in list] [next in list] [prev in thread] [next in thread]