[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8328977 : JEditorPane.setPage not thread-safe, pageLoader not cancelled [v3]
From:       Tejesh R <tr () openjdk ! org>
Date:       2024-04-23 6:15:29
Message-ID: Ps4uriCyLspGqHwhsQwlOJLGHLLpYHiO66oG24Xrco0=.71777fcd-2a98-448c-8fe0-8285a22e52c0 () github ! com
[Download RAW message or body]

On Fri, 19 Apr 2024 14:53:09 GMT, Renjith Kannath Pariyangad \
<rkannathpari@openjdk.org> wrote:

> > Hi Reviewers,
> > 
> > Added pageloader cancel before new page creation along with code restructuring. \
> > Moved all page loading calls inside synchronize to make it thread safe. 
> > Regards,
> > Renjith.
> 
> Renjith Kannath Pariyangad has updated the pull request incrementally with one \
> additional commit since the last revision: 
> Rearranged if based on suggesion

LGTM

-------------

Marked as reviewed by tr (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18670#pullrequestreview-2016320923


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic