[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8330178: Clean up non-standard use of /** comments in `java.base` [v2]
From:       Iris Clark <iris () openjdk ! org>
Date:       2024-04-23 2:35:31
Message-ID: QuHZeejL48phB87kuWRWzlunHQ6KGRSVvyNNCVjTFzk=.1edeb3eb-3cd6-4ed3-a0b5-1a39937dd7e3 () github ! com
[Download RAW message or body]

On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons <jjg@openjdk.org> wrote:

> > Please review a set of updates to clean up use of `/**` comments in the vicinity \
> > of declarations. 
> > There are various categories of update:
> > 
> > * "Box comments" beginning with `/**`
> > * Misplaced doc comments before package or import statements
> > * Misplaced doc comments after the annotations for a declaration
> > * Dangling `/**` comments relating to a group of declarations, separate from the \
> >                 doc comments for each of those declarations
> > * Use of `/**` for the legal header at or near the top of the file
> > 
> > In one case, two doc comments before a declaration were merged, which fixes a \
> > bug/omission in the documented serialized form.
> 
> Jonathan Gibbons has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Update src/java.base/share/classes/sun/net/www/protocol/file/FileURLConnection.java
> 
> Fix grammatical typo
> 
> Co-authored-by: Alexey Ivanov <alexey.ivanov@oracle.com>

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18846#pullrequestreview-2016126206


[prev in list] [next in list] [prev in thread] [next in thread]