[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v13]
From:       Alexey Ivanov <aivanov () openjdk ! org>
Date:       2024-03-29 19:33:36
Message-ID: aHf4RoiQkqVJbIo-rLdXlbmWPtPXg0OBKgRXLDfibSM=.260b7011-3830-4329-bc1e-0036bc099f84 () github ! com
[Download RAW message or body]

On Thu, 7 Mar 2024 09:27:10 GMT, Renjith Kannath Pariyangad \
<rkannathpari@openjdk.org> wrote:

> > Hi Reviewers,
> > 
> > Updated manual printer test cases with 'PassFailJFrame', also removed unused \
> > variables. Added 'SkippedException' in case of printer missing or not configured. \
> >  Please review and let me know your suggestions.
> > 
> > Regards,
> > Renjith
> 
> Renjith Kannath Pariyangad has updated the pull request incrementally with one \
> additional commit since the last revision: 
> Updated instructions

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/print/PrinterJob/PrintAllFonts.java line 62:

> 60:         }
> 61: 
> 62:         PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()

Suggestion:

        PassFailJFrame passFailJFrame = PassFailJFrame.builder()

You have to use the `builder()` method, otherwise the test will fail to compile after \
integration. See PR #18206 for \
[JDK-8325851](https://bugs.openjdk.org/browse/JDK-8325851).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17607#pullrequestreview-1969477088
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1544807647


[prev in list] [next in list] [prev in thread] [next in thread]