[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v10]
From:       Alexey Ivanov <aivanov () openjdk ! org>
Date:       2024-03-29 19:08:34
Message-ID: EqSoaPUaL5MZcRR-dN3BoF6I9PjdwMwDz5lnudXdIS0=.8330b860-530d-4ddb-92ee-dfb0c48aff88 () github ! com
[Download RAW message or body]

On Tue, 5 Mar 2024 13:15:04 GMT, Alexey Ivanov <aivanov@openjdk.org> wrote:

> > Renjith Kannath Pariyangad has updated the pull request incrementally with one \
> > additional commit since the last revision: 
> > Updated instruction
> 
> test/jdk/java/awt/print/PrinterJob/DrawImage.java line 93:
> 
> > 91:         if (pj.printDialog()) {
> > 92:             pj.print();
> > 93:         }
> 
> Fail the test if the tester clicks Cancel in the print dialog?

I still think the test should fail if Cancel is clicked in the Print dialog.

The test does not provide an option to do it again.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1544776413


[prev in list] [next in list] [prev in thread] [next in thread]