[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8328648: Remove applet usage from JFileChooser tests bug4150029 [v8]
From:       Abhishek Kumar <abhiscxk () openjdk ! org>
Date:       2024-03-29 16:46:32
Message-ID: vSQO8SIfI94EJ_WEUt5cAF3GAAQBhEyJncc_37F5Xbs=.7b7d7edd-4473-47bc-ab3b-5d418f40c7fa () github ! com
[Download RAW message or body]

On Fri, 29 Mar 2024 14:37:42 GMT, Alisen Chung <achung@openjdk.org> wrote:

> > Removing applet usage from manual JFileChooser tests
> 
> Alisen Chung has updated the pull request incrementally with one additional commit \
> since the last revision: 
> move var into local, simplified condition check, spacing

Looks good now. Only point is "should we move this test outside folder as html file \
is deleted now?". Hope you have tested in CI for all platform.

-------------

Marked as reviewed by abhiscxk (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18415#pullrequestreview-1969011787


[prev in list] [next in list] [prev in thread] [next in thread]