[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide in Windows LAF when F10 is pres
From:       Abhishek Kumar <abhiscxk () openjdk ! org>
Date:       2024-02-29 17:36:53
Message-ID: 3p9qsqAfBx2h0KL9yCjZPrXMSjWa-SIzgLDA_q0612k=.de4538bc-ba5d-4740-8f7a-46e822f58cac () github ! com
[Download RAW message or body]

On Thu, 29 Feb 2024 11:02:35 GMT, Alexey Ivanov <aivanov@openjdk.org> wrote:

> > Abhishek Kumar has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > Review comment update
> 
> src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsMenuBarUI.java \
> line 152: 
> > 150:                 //MenuElement[] path = new MenuElement[2];
> > 151:                 //path[0] = (MenuElement)menuBar;
> > 152:                 //path[1] = (MenuElement)menu;
> 
> Do not leave commented out code. The source control system is used to record the \
> history. 
> If you want to keep the old way, you can still do it by replacing one line
> 
> MenuElement[] path = {menuBar, menu};
> 
> inside `else` with these three lines.

Oh! my bad. I pushed it by mistake. Will update in next iteration.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1507946680


[prev in list] [next in list] [prev in thread] [next in thread]