[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8326583: Remove over-generalized DefineNativeToolchain solution [v4]
From:       Julian Waters <jwaters () openjdk ! org>
Date:       2024-02-27 12:50:48
Message-ID: wuo24mj4CQl0UsYobcdJcyJAlMNP9lENjN48QDaeEXw=.6fc92cd3-9671-487c-ae05-df8fbf16fdce () github ! com
[Download RAW message or body]

On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie <ihse@openjdk.org> wrote:

> > The idea of setting up general "toolchains" in the native build was good, but it \
> > turned out that we really only need a single toolchain, with a single twist: if \
> > it should use CC or CPP to link. This is better described by a specific argument \
> > to SetupNativeCompilation, LANG := C++ or LANG := C (the default). 
> > There is a single exception to this rule, and that is if we want to compile for \
> > the build platform rather than the target platform. (This is only done for adlc) \
> > To keep expressing this difference, introduce TARGET_TYPE := BUILD (or \
> > TARGET_TYPE := TARGET, the default). 
> > The final odd-case was the hack for building hsdis/bin on mingw. This can be \
> > resolved using direct variables to SetupNativeCompilation, instead of first \
> > creating a toolchain. 
> > Doing this refactoring will simplify the SetupNativeCompilation code, and make it \
> > much clearer if we use the C or C++ linker.
> 
> Magnus Ihse Bursie has updated the pull request with a new target base due to a \
> merge or a rebase. The pull request now contains five commits: 
> - Merge branch 'master' into remove-toolchain-define
> - Rename LANG to LINK_TYPE
> - Reword "lib" comment to fit in better
> - Merge branch 'master' into remove-toolchain-define
> - 8326583: Remove over-generalized DefineNativeToolchain solution

I can't really say I agree, but I guess we'll see where this goes from here first

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17986#issuecomment-1966471047


[prev in list] [next in list] [prev in thread] [next in thread]