[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Integrated: 8326583: Remove over-generalized DefineNativeToolchain solution
From:       Magnus Ihse Bursie <ihse () openjdk ! org>
Date:       2024-02-27 11:19:59
Message-ID: pK_M8V-MQoCXBRHBsUHz2EVWBVELkftarz89Km-t8CU=.23d9fae7-58ed-4810-bc26-68a438a75025 () github ! com
[Download RAW message or body]

On Fri, 23 Feb 2024 16:23:43 GMT, Magnus Ihse Bursie <ihse@openjdk.org> wrote:

> The idea of setting up general "toolchains" in the native build was good, but it \
> turned out that we really only need a single toolchain, with a single twist: if it \
> should use CC or CPP to link. This is better described by a specific argument to \
> SetupNativeCompilation, LANG := C++ or LANG := C (the default). 
> There is a single exception to this rule, and that is if we want to compile for the \
> build platform rather than the target platform. (This is only done for adlc) To \
> keep expressing this difference, introduce TARGET_TYPE := BUILD (or TARGET_TYPE := \
> TARGET, the default). 
> The final odd-case was the hack for building hsdis/bin on mingw. This can be \
> resolved using direct variables to SetupNativeCompilation, instead of first \
> creating a toolchain. 
> Doing this refactoring will simplify the SetupNativeCompilation code, and make it \
> much clearer if we use the C or C++ linker.

This pull request has now been integrated.

Changeset: ac3ce2aa
Author:    Magnus Ihse Bursie <ihse@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ac3ce2aa156332fc4e6f33018ff669657ab4b797
                
Stats:     231 lines in 14 files changed: 58 ins; 142 del; 31 mod

8326583: Remove over-generalized DefineNativeToolchain solution

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/jdk/pull/17986


[prev in list] [next in list] [prev in thread] [next in thread]