[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: JDK-8324238 : [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails w
From:       Alexander Zvegintsev <azvegint () openjdk ! org>
Date:       2024-01-31 9:57:02
Message-ID: WXblSCADKm4cnruGVxYR58sY1mQLZb6Aq60CSZ1vaO8=.d21bb596-cc0b-4fe9-8204-57bdedf5db80 () github ! com
[Download RAW message or body]

On Wed, 31 Jan 2024 01:08:13 GMT, Harshitha Onkar <honkar@openjdk.org> wrote:

> > ShapeNotSetSometimes.java fails on macOS 11 on a random iteration of \
> > `colorCheck()` as shown below. The `colorCheck()` is repeated for about 50 times \
> > in the test. It is observed to pass on previous attempts and fail on a random \
> > attempt such as Attempt# 29 shown here. 
> > Here the point (150, 20) is well in the green area hence the slight color diff \
> > picked up by `robot.getPixelColor()` is not due to sampling of color at the edge \
> > (which sometimes causes robot to pick up slightly different color).   
> > 
> > Attempt 29
> > Checking 150, 20, java.awt.Color[r=0,g=255,b=1] should be \
> > java.awt.Color[r=0,g=255,b=0] 
> > 
> > Due to the above, I have kept the color sampling points at the same location as \
> > earlier and made the following changes to the test: 
> > - Moved the frame to the center of the screen.
> > - Instead of comparing exact RGB values, used `colorCompare()` which allows color \
> > tolerance of 2 per color component to accommodate slight variations when \
> > comparing actual vs expected colors. 
> > 
> > 
> > Attempt 27
> > Checking 150, 130, java.awt.Color[r=255,g=255,b=255] should be \
> > java.awt.Color[r=255,g=255,b=255] Checking 150, 20, java.awt.Color[r=0,g=255,b=0] \
> > should be java.awt.Color[r=0,g=255,b=0] Checking 280, 120, \
> > java.awt.Color[r=0,g=255,b=0] should be java.awt.Color[r=0,g=255,b=0] Checking \
> > 150, 250, java.awt.Color[r=0,g=255,b=0] should be java.awt.Color[r=0,g=255,b=0] \
> > Checking 20, 120, java.awt.Color[r=0,g=255,b=0] should be \
> > java.awt.Color[r=0,g=255,b=0] Checking 62, 62, java.awt.Color[r=0,g=243,b=0] \
> > should not be java.awt.Color[r=255,g=255,b=255] Checking 240, 185, \
> > java.awt.Color[r=0,g=229,b=0] should not be java.awt.Color[r=255,g=255,b=255] \
> > Attempt 28 Checking 150, 130, java.awt.Color[r=255,g=255,b=255] should be \
> > java.awt.Color[r=255,g=255,b=255] Checking 150, 20, java.awt.Color[r=0,g=255,b=0] \
> > should be java.awt.Color[r=0,g=255,b=0] Checking 280, 120, \
> > java.awt.Color[r=0,g=255,b=0] should be java.awt.Color[r=0,g=255,b=0] Checking \
> > 150, 250, java.awt.Color[r=0,g=255,b=0] should be java.awt.Color[r=0,g=255,b=0] \
> > Checking 20, 120, java.awt.Color[r=0,g=255,b=0] should be \
> > java.awt.Color[r=0,g=255,b=0] Checking 62, 62, java.awt.Color[r=0,g=241,b=0] \
> > should not be java.awt.Color[r=255,g=255,b=255] Checking 240, 185, \
> > java.awt.Color[r=0,g=227,b=0] should not be java.awt.Color[r=255,g=255,b=255] \
> > Attempt 29 Checking 150, 130, java.awt.Color[r=255,g=255,b=255] should be \
> > java.awt.Color[r=255,g=255,b=255] Checking 150, 20, java.awt.Color[r=0,...
> 
> Harshitha Onkar has updated the pull request incrementally with one additional \
> commit since the last revision: 
> test update

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17563#pullrequestreview-1853319620


[prev in list] [next in list] [prev in thread] [next in thread]