[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v4]
From:       Matthias Baesken <mbaesken () openjdk ! org>
Date:       2024-01-31 9:22:07
Message-ID: FXqfV9eIuqQE5fj65sXIKoou-w-ZOko1PbtbISfMIRQ=.558df97e-2941-47d0-9a45-1c450cf6dc39 () github ! com
[Download RAW message or body]

On Tue, 30 Jan 2024 14:15:57 GMT, Magnus Ihse Bursie <ihse@openjdk.org> wrote:

> > Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should \
> > use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK native \
> > libraries.
> 
> Magnus Ihse Bursie has updated the pull request with a new target base due to a \
> merge or a rebase. The incremental webrev excludes the unrelated changes brought in \
> by the merge/rebase. The pull request contains seven additional commits since the \
> last revision: 
> - Merge branch 'master' into jdk-FOB64
> - Move #include <stdlib/io.h> out of debug_util.h
> - Restore AIX dirent64 et al defines
> - Rollback AIX changes since they are now tracked in JDK-8324834
> - Remove superfluous setting of FOB64
> - Replace all foo64() with foo() for large-file functions in the JDK
> - 8324539: Do not use LFS64 symbols in JDK libs

After adding this additional patch I  fully build fastdebug on AIX (hav to admit it \
does not look very nice).


diff --git a/src/java.desktop/share/native/libawt/java2d/pipe/BufferedRenderPipe.c \
b/src/java.desktop/share/native/libawt/java2d/pipe/BufferedRenderPipe.c index \
                823475b0a23..ee0109b6806 100644
--- a/src/java.desktop/share/native/libawt/java2d/pipe/BufferedRenderPipe.c
+++ b/src/java.desktop/share/native/libawt/java2d/pipe/BufferedRenderPipe.c
@@ -31,6 +31,10 @@
 #include "SpanIterator.h"
 #include "Trace.h"
 
+#if defined(_AIX) && defined(open)
+#undef open
+#endif
+
 /* The "header" consists of a jint opcode and a jint span count value */
 #define INTS_PER_HEADER  2
 #define BYTES_PER_HEADER 8

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17538#issuecomment-1918699480


[prev in list] [next in list] [prev in thread] [next in thread]