[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8259550: The content of the print out displayed incomplete with the NimbusLAF [v6]
From:       Damon Nguyen <dnguyen () openjdk ! org>
Date:       2024-01-31 1:22:05
Message-ID: rDG7I3YPzJr6-H1y15-4muDMwmYDGTKQJGCVD4G7tMI=.520ee16e-89f3-46ed-ad2a-2acd69e99196 () github ! com
[Download RAW message or body]

On Tue, 30 Jan 2024 11:41:44 GMT, Tejesh R <tr@openjdk.org> wrote:

> > The issue is w.r.t to way that Synth prints the table. In Synth, the printing of \
> > Table happens column wise by painting blocks of columns which is due to the fact \
> > that Graphics used which is `ProxyGrpahics2D` (which get selected in \
> > `RasterPrinterJob `class, otherwise it would be `WPathGraphics` for other Look \
> > and feel).  Since the printing happens in block wise and the columns where the x \
> > position is greater than the `table.bounds` doesn't gets painted because of the \
> > intersection check condition `!bounds.intersects(clip)`. Hence only droplines are \
> > painted instead of cells and gridlines.  I couldn't find any reason for adding \
> > the intersection check here and when removed it didn't cause any regression too, \
> > rather it solves the issue and actually made sense too. In other Look and Feel \
> > its not required to apply the fix (in `BasicTableUI `class) because its not \
> > affecting anything yet since the painting happens for whole table. Hence \
> > proposing the fix for only SynthTableUI class. \
> > ([PrintManualTest_FitWidthMultiple.java](https://github.com/openjdk/jdk/blob/master/test/jdk/javax/swing/JTable/PrintManualTest_FitWidthMultiple.java)) \
> > test is been used for testing.
> 
> Tejesh R has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Test updated for default L&F

I re-ran doing the same as Prasanta on Windows 11. LGTM now.

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/17053#pullrequestreview-1852727738


[prev in list] [next in list] [prev in thread] [next in thread]