[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v1
From:       Prasanta Sadhukhan <psadhukhan () openjdk ! org>
Date:       2024-01-29 13:10:03
Message-ID: EoSiiF-1tMvUxajUsJuWL57OBee386rn5OHZFdO5I0U=.4df3bc3b-45b1-4274-b6a9-201280c2e808 () github ! com
[Download RAW message or body]

> javadoc contract for JComponent.setMinimumSize(Dimension) states:
> 
> "Sets the minimum size of this component to a constant value. Subsequent calls to \
> getMinimumSize will always return this value..." 
> However, JScrollBar overrides getMinimumSize() and breaks this contract - it always \
> returns a minimum size derived from the preferred size even if you have previously \
> called setMinimumSize() 
> Fix is made to check if mnimumSize is set and if so, honour it..

Prasanta Sadhukhan has updated the pull request incrementally with one additional \
commit since the last revision:

  review update

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15325/files
  - new: https://git.openjdk.org/jdk/pull/15325/files/1d8fff40..4937fccc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15325&range=14
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15325&range=13-14

  Stats: 6 lines in 2 files changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/15325.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15325/head:pull/15325

PR: https://git.openjdk.org/jdk/pull/15325


[prev in list] [next in list] [prev in thread] [next in thread]