[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8316931: [macos14] Test "java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.html" 
From:       Alisen Chung <achung () openjdk ! org>
Date:       2024-01-27 5:57:51
Message-ID: SpGE51ZkF5__NcrFxehYPq_uv59wdNegqGBAHmfgKmI=.e0677853-129c-4574-8e55-673ba244f494 () github ! com
[Download RAW message or body]

> SunToolkit.java is trying to post an event on the TrayIcon appContext, but the \
> TrayIcon was already removed by the test, causing an error. The fix is to make \
> SunToolkit skip posting the event if appContext is null. The test is also updated \
> to remove applet usage and use PassFailJFrame instead.

Alisen Chung has updated the pull request with a new target base due to a merge or a \
rebase. The incremental webrev excludes the unrelated changes brought in by the \
merge/rebase. The pull request contains 10 additional commits since the last \
revision:

 - Merge branch 'master' of https://github.com/openjdk/jdk into 8316931
 - remove null check in SunToolkit, remove setting target to null in CTrayIcon
 - Merge branch 'master' of https://github.com/openjdk/jdk into 8316931
 - added suggested changes, moved test back into folder
 - added suggested changes, moved test back into folder
 - used jtreg.SkippedException, updated copyright years
 - removed extra newlines, moved test out of folder
 - spacing
 - updated test title, copyright year, removed redundant check
 - removed applet usage in test, fixed event posted on wrong app context bug

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17329/files
  - new: https://git.openjdk.org/jdk/pull/17329/files/fed411c1..96e0590d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17329&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17329&range=06-07

  Stats: 18 lines in 2 files changed: 15 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/17329.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17329/head:pull/17329

PR: https://git.openjdk.org/jdk/pull/17329


[prev in list] [next in list] [prev in thread] [next in thread]