[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Integrated: 8320692: Null icon returned for .exe without custom icon
From:       Alexander Zuev <kizune () openjdk ! org>
Date:       2024-01-24 22:13:36
Message-ID: RfQOFwM_t7JYmkG61hnDw6uRTMJQkk3MQpf_O3hG8FU=.2e30b1f9-dc7d-4ca0-8359-6303d94f775e () github ! com
[Download RAW message or body]

On Thu, 18 Jan 2024 00:47:00 GMT, Alexander Zuev <kizune@openjdk.org> wrote:

> Replaced asserts with NullPointerException calls because outside of testing that \
> would be more informative - i do not think many people running their applications \
> with assertions in system libraries enabled; Added a code that will analyze the \
> result of the getIcon and will fall back to the default icon for the file type \
> retrieved from the ShellFolder; Added a test case made by Aleksei Ivanov.

This pull request has now been integrated.

Changeset: 6212264c
Author:    Alexander Zuev <kizune@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/6212264cc6fe428e8d15b7f33e2979c081e432d7
                
Stats:     282 lines in 2 files changed: 280 ins; 0 del; 2 mod

8320692: Null icon returned for .exe without custom icon

Co-authored-by: Alexey Ivanov <aivanov@openjdk.org>
Reviewed-by: aivanov

-------------

PR: https://git.openjdk.org/jdk/pull/17475


[prev in list] [next in list] [prev in thread] [next in thread]