[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    RFR: JDK-8320405: [Windows Server 2016] java/awt/image/MultiResolutionImage/MultiResolutionImageObse
From:       Matthias Baesken <mbaesken () openjdk ! org>
Date:       2023-12-28 9:54:57
Message-ID: A-ey34iRMjhOnwJSIEv7uZpGAj_EcP4NAwVobyVxBbg=.ceb9e3df-cba8-4fb6-90f2-bc46c962cdf1 () github ! com
[Download RAW message or body]

When running with fastdebug binaries we run intermittent into the issue below in
jtreg test java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java \
. Seems we miss checking of successful HBITMAP creation before calling GetDIBits.

  HDC hBMDC = this->GetDC();
  HBITMAP hBM = ::CreateCompatibleBitmap(hBMDC, 1, 1);
  VERIFY(::GetDIBits(hBMDC, hBM, 0, 1, NULL, gpBitmapInfo, DIB_RGB_COLORS));

in awt_Win32GraphicsDevice.cpp . Thats why the releast of hBMDC / hBM fails as well \
at the end of the function causing the seond and third warning.


Sat Nov 18 17:29:23 CET 2023

*********************
AWT Assertion Failure
*********************
> > GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0)
File 'e:\openjdk\openjdk-21u-windows_x86_64-dbg\jdk\src\java.desktop\windows\native\libawt\windows\awt_Win32GraphicsDevice.cpp', \
at line 184 GetLastError() is 57 : The parameter is incorrect.

Do you want to break into the debugger?
*********************
*********************
AWT Assertion Failure
*********************
> > DeleteObject(hBM)
File 'e:\openjdk\openjdk-21u-windows_x86_64-dbg\jdk\src\java.desktop\windows\native\libawt\windows\awt_Win32GraphicsDevice.cpp', \
at line 297 GetLastError() is 57 : The parameter is incorrect.

So it seems, we should have some additional checks/tracing.

-------------

Commit messages:
 - JDK-8320405

Changes: https://git.openjdk.org/jdk/pull/17197/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17197&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8320405
  Stats: 14 lines in 1 file changed: 12 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/17197.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17197/head:pull/17197

PR: https://git.openjdk.org/jdk/pull/17197


[prev in list] [next in list] [prev in thread] [next in thread]