[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: WindowsLookAndFeel change in JDK 22
From:       Aleksei Ivanov <alexey.ivanov () oracle ! com>
Date:       2023-12-20 17:44:07
Message-ID: 0e5b9994-5e2b-40e3-813f-d9ff6d5957f8 () oracle ! com
[Download RAW message or body]

Hi Simon,

On 2023-12-15 22:04, Simon Nash wrote:
> Thanks for looking into this. I'm commenting here because I don't 
> think I am able to to add comments in JDK-8321151.

To add comments to JBS, you have to have a role the OpenJDK Census [7].

> if exact scaling is difficult, any reasonable approximation would be 
> better than falling back to the Windows NT LookAndFeel, as Phil Race 
> has commented in JDK-8321151.

Rajat is working on a fix, the fallback behaviour will be the same as it 
was before JDK-8294427. Once a PR is open, you'll be able to take the 
code changes for testing, however, you'll need to build JDK yourself. 
The PR will be announced with a message to the 
client-libs-dev@openjdk.org mailing list, as usual. If you're subscribed 
to the mailing list, you'll get the message in your inbox, 
alternatively, you can view the archives [8].

> On 11/12/2023 15:01, Aleksei Ivanov wrote:
>> This has been tracked down to be a regression of JDK-8294427 [1] 
>> which introduced the dependency on the OpenThemeDataForDpi [2] 
>> function from Windows API. The function is available since Windows 10 
>> version 1703.
>>
>> The code review [3] for JDK-8294427 has a discussion [4] on whether 
>> support for older versions of Windows should be considered.
>>
>> At that time, it was deemed infeasible [5] to provide this support.
>>
>> The compatibility problem is now tracked as JDK-8321151 [6].
>>
>>
>> [1] https://bugs.openjdk.org/browse/JDK-8294427
>> [2] 
>> https://learn.microsoft.com/en-us/windows/win32/api/uxtheme/nf-uxtheme-openthemedatafordpi
>> [3] https://github.com/openjdk/jdk/pull/13701
>> [4] https://github.com/openjdk/jdk/pull/13701#discussion_r1180829485
>> [5] https://github.com/openjdk/jdk/pull/13701#discussion_r1227202738
>> [6] https://bugs.openjdk.org/browse/JDK-8321151
[7] https://openjdk.org/census
[8] https://mail.openjdk.org/pipermail/client-libs-dev/

-- 
Regards,
Alexey
[prev in list] [next in list] [prev in thread] [next in thread]