[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8317288: [macos] java/awt/Window/Grab/GrabTest.java: Press on the outside area didn't cause
From:       Alexander Zvegintsev <azvegint () openjdk ! org>
Date:       2023-11-30 7:25:06
Message-ID: PiexOSh7WrxLPRmBmJPSBiTwO8jcGLjbMRLW-jDqEJs=.d0c0eb6c-fb1d-4818-8676-3c697c4ad3ae () github ! com
[Download RAW message or body]

On Tue, 28 Nov 2023 22:34:44 GMT, Alisen Chung <achung@openjdk.org> wrote:

> Added delays to stabilize test, test passes 50 times consecutively

test/jdk/java/awt/Window/Grab/GrabTest.java line 118:

> 116: 
> 117:         f.setVisible(true);
> 118:         w.setVisible(true);

Since you are already touching this test, all the GUI work can be moved to the EDT.

test/jdk/java/awt/Window/Grab/GrabTest.java line 119:

> 117:         f.setVisible(true);
> 118:         w.setVisible(true);
> 119:         Util.waitForIdle(robot);

Adding a delay could also improve the test stability (as you already did on lines 247 \
and 253).  However, our usual practice is to add a 500-1000 ms delay after showing a \
frame to make it work even on really slow machines.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16867#discussion_r1410250980
PR Review Comment: https://git.openjdk.org/jdk/pull/16867#discussion_r1410223413


[prev in list] [next in list] [prev in thread] [next in thread]