[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Integrated: JDK-8318854: [macos14] Running any AWT app prints Secure coding warning
From:       Harshitha Onkar <honkar () openjdk ! org>
Date:       2023-11-29 21:56:16
Message-ID: pj96vxFHONCXtff4wlEwMnZFmWhF2tWktOqPPs67wXk=.996330b2-8c1a-4422-a2b3-77b5cdfde743 () github ! com
[Download RAW message or body]

On Wed, 8 Nov 2023 19:49:48 GMT, Harshitha Onkar <honkar@openjdk.org> wrote:

> With Xcode upgraded to 14.3.1 for macOS builds secure coding warning message was \
> seen in the logs as below: 
> "WARNING: Secure coding is not enabled for restorable state! Enable secure coding \
> by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState: and \
> returning YES." 
> which requires AppDelegate to explicitly implement \
> applicationSupportsSecureRestorableState() to return true as mentioned here in \
> [Apple Release notes](https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-14#Restorable-State).
>  
> While investigating JFX embedded scenario (Swing components in FX window) another \
> issue observed was that the AWT was overriding the FX delegate causing the app to \
> crash in certain scenarios. This issue is also being fixed in this PR and also as \
> part of [JDK-8319669](https://bugs.openjdk.org/browse/JDK-8319669) , \
> https://github.com/openjdk/jfx/pull/1280. 
> The fix for JDK-8318854 involves:
> 
> - implementing applicationSupportsSecureRestorableState() in ApplicationDelegate.m \
> & QueuingApplicationDelegate.m to return YES  by default, unless the env var - \
> **AWT_DISABLE_NSDELEGATE_SECURE_SAVE**  is defined. 
> - Fix added to stop AWT toolkit from overriding a delegate set by another \
> NSApplication by default. There is an option to restore the old behavior by \
> defining the env var - **AWT_OVERRIDE_NSDELEGATE**. 
> - Null checks are added for shared delegate in cases where it can be null and cause \
> issues in AWTWindow.m, CMenuBar.m, ApplicationDelegate.m 
> Test scenarios involving JDK and JFX fixes is documented here 
> [Updated_Test_Scenarios.xlsx](https://github.com/openjdk/jdk/files/13491545/Updated_Test_Scenarios.xlsx)
>  
> 
> **PLEASE NOTE !!**  The environment variables being added as part of this fix are \
> for debugging only and should NOT be used for application purpose. As such they \
> will NOT be documented.

This pull request has now been integrated.

Changeset: 940f67c1
Author:    Harshitha Onkar <honkar@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/940f67c1a62c6f9462266f3a108649aca114cffa
                
Stats:     66 lines in 4 files changed: 42 ins; 2 del; 22 mod

8318854: [macos14] Running any AWT app prints Secure coding warning

Reviewed-by: kcr, kizune, prr

-------------

PR: https://git.openjdk.org/jdk/pull/16569


[prev in list] [next in list] [prev in thread] [next in thread]