[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8224261: JProgressBar always with border painted around it [v7]
From:       Alexey Ivanov <aivanov () openjdk ! org>
Date:       2023-11-23 9:45:11
Message-ID: 8Xmg3c7FTDI1q1UuhPyrBeqSDVD493s-UlacxZ6295k=.8ae76794-0e0f-4590-ace3-12312c42b081 () github ! com
[Download RAW message or body]

On Wed, 22 Nov 2023 04:25:38 GMT, Abhishek Kumar <abhiscxk@openjdk.org> wrote:

> > JProgressBar is always painted with border irrespective of the value set via the \
> > API `setBorderPainted(boolean value)` in Synth (Nimbus and GTK) LAF. Proposed fix \
> > is to add a check before painting the component. 
> > CI jobs are green after the fix. Links attached to JBS.
> 
> Abhishek Kumar has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Minor fix

Looks good to me.

I would sort the imports though.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16467#pullrequestreview-1744485512


[prev in list] [next in list] [prev in thread] [next in thread]