[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8318091: Remove empty initIDs functions
From:       Alexey Ivanov <aivanov () openjdk ! org>
Date:       2023-10-27 11:12:36
Message-ID: uoJbMvKSTCW8TEjWsdzjuaDidqmG2Ze5mhJPR8XKevI=.0ed217d1-e60b-460d-8722-45d31286390d () github ! com
[Download RAW message or body]

On Thu, 26 Oct 2023 06:56:16 GMT, Daniel Jeliński <djelinski@openjdk.org> wrote:

> The removed functions are empty on all platforms.
> 
> This patch also removes calls to `Toolkit.loadLibraries();` in classes that no \
> longer have any native methods. The call was needed to ensure that the native awt \
> library is loaded. 
> Client libs tests passed.

> Button extends Component, which loads libraries
> FileDialog extends Dialog, which loads libraries

Then it's handled, obviously. `TextField` falls into the same category.

And `KeyboardFocusManager` will also load the libraries because it depends on the \
`Toolkit` class which, in its turn, loads the libraries.

We're good then, no further changes needed. Thank you!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16372#issuecomment-1782729139


[prev in list] [next in list] [prev in thread] [next in thread]