[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8169475 : WheelModifier.java fails by timeout [v4]
From:       Dmitry Markov <dmarkov () openjdk ! org>
Date:       2023-10-26 18:05:36
Message-ID: ITjdm2pPEkPGGtHGyFZAEaydalJykoF4YupJwBndn-E=.54550632-6280-4652-aece-3eeb83db5517 () github ! com
[Download RAW message or body]

On Thu, 26 Oct 2023 06:11:50 GMT, Renjith Kannath Pariyangad <duke@openjdk.org> \
wrote:

> > Hi Reviewers,
> > 
> > I have added additional CountDownLatch for making sure button is visible before \
> > proceeding,(observe this was one of the key reason for failure) so this helps to \
> > improve test case stability. Modified _await()_ function by adding 1sec timeout \
> > with exception, this will help to reduce total execution time in case of failure. \
> >  Please review and let me know your suggestions, if any.
> 
> Renjith Kannath Pariyangad has updated the pull request incrementally with one \
> additional commit since the last revision: 
> Made thread safe

Marked as reviewed by dmarkov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/16281#pullrequestreview-1700218268


[prev in list] [next in list] [prev in thread] [next in thread]