[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v7]
From:       Abhishek Kumar <abhiscxk () openjdk ! org>
Date:       2023-09-29 5:08:11
Message-ID: MNvmSANb4rRPEFnFxhvV5lYFoQ0D1G2bvLVRGxEq_Pg=.d14630e3-c9e0-4564-a375-7248a31e89b5 () github ! com
[Download RAW message or body]

On Fri, 1 Sep 2023 06:05:09 GMT, Alexander Zuev <kizune@openjdk.org> wrote:

> > Abhishek Kumar has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > Revert BasicComboBoxUI fix and update review comment
> 
> src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxButton.java line 253:
> 
> > 251: 
> > 252:         // set the accessible name to the displayed text in JComboBox.
> > 253:         // screen magnifier queries to get the accessible name to display \
> > magnified text.
> 
> I still do not think that setting accessible name in paint is a good idea. Setting \
> it during the initialization and adding a property change listener to the \
> accessible context to track changes seems like a better way to do it.

@azuev-java Please review.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1340902980


[prev in list] [next in list] [prev in thread] [next in thread]