[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8316206: Test StretchedFontTest.java fails for Baekmuk font [v2]
From:       Goetz Lindenmaier <goetz () openjdk ! org>
Date:       2023-09-27 6:22:23
Message-ID: WZ7yuTLC4d-0mCNEq2BHNHWzj2mtN8I33kaqfA-KKAM=.d274a34f-1d69-4a1b-8590-1c4f9e67df63 () github ! com
[Download RAW message or body]

On Wed, 20 Sep 2023 14:07:17 GMT, Alexey Ivanov <aivanov@openjdk.org> wrote:

> > **Root cause**
> > 
> > The _Baekmuk Headline_ font maps `\u6f22` (漢) to glyph id 16950 which has zero \
> > length. 
> > The test fails if the right half of the image with the rendered glyph contains \
> > only pixels of background colour. In this case, the left half of the image is \
> > also blank. It's somewhat false positive because of the broken font. 
> > **Fix**
> > 
> > Ignore fonts which don't render the glyph correctly. If the left half of the \
> > image contains pixels of the background colour only, it is expected that the \
> > right half also contains background-coloured pixels only. 
> > The updated test does not fail with the _Baekmuk Headline_ font. It still detects \
> > the original problem and fails on builds without the fix for \
> > [JDK-8312555](https://bugs.openjdk.org/browse/JDK-8312555).
> 
> Alexey Ivanov has updated the pull request incrementally with one additional commit \
> since the last revision: 
> 8316206: Use GlyphVector.getVisualBounds().isEmpty()
> 
> Filter out broken fonts by GlyphVector.getVisualBounds().isEmpty()

Thanks for this timely fix!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15818#issuecomment-1736770130


[prev in list] [next in list] [prev in thread] [next in thread]