[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8312075: FileChooser.win32.newFolder is not updated when changing Locale [v5]
From:       Tejesh R <tr () openjdk ! org>
Date:       2023-08-31 20:45:54
Message-ID: kTOhqNpoJphN072p6iQdkBVX-_wuaJ0gTNniCjnhxs0=.4573294c-a57e-4ed6-971e-65f49cda6571 () github ! com
[Download RAW message or body]

On Thu, 31 Aug 2023 15:59:35 GMT, Tejesh R <tr@openjdk.org> wrote:

> > Yes, a helper method which deletes a directory that you pass as a parameter and \
> > prints an error if it fails. 
> > Then removing the two directories is a matter of calling this method twice: for \
> > the English and French directory. 
> > You just got the condition wrong, it seems. The one you used previously looked \
> > correct.
> 
> The previous one had an issue when `newFolderEnglish` / `newFolderFrench` is null. \
> The updated one is right.

Then I have updated with helper method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15069#discussion_r1311857365


[prev in list] [next in list] [prev in thread] [next in thread]