[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8315097: Rename createJavaProcessBuilder [v3]
From:       Mark Sheppard <msheppar () openjdk ! org>
Date:       2023-08-31 10:11:02
Message-ID: vCLRZwJrzYryyifx7o1JmbNDvnCt9bPwJKPd3DqOR30=.447ed116-dbae-4192-8300-ac7eaba309b3 () github ! com
[Download RAW message or body]

On Thu, 31 Aug 2023 05:45:27 GMT, David Holmes <dholmes@openjdk.org> wrote:

> > So you could create a single createJavaProcessBuilder with add an additional \
> > parameter boolean addTestOpts e.g. createJavaProcessBuilder(List command, boolean \
> > addTestOpts) { ... }
> 
> @msheppar that is actually where we started, and it was then split into two \
> differently named methods to "make it clear" which one included the test opts \
> without having to remember the name of the parameter that the true/false argument \
> was bound to.

cheers David  thanks for the clarification on background

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15452#issuecomment-1700749844


[prev in list] [next in list] [prev in thread] [next in thread]