[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8311922: [macOS] right-Option key fails to generate release event [v5]
From:       Damon Nguyen <dnguyen () openjdk ! org>
Date:       2023-08-30 18:23:11
Message-ID: 7up425zS1Lqn-tv682RjKQI0XixPUyzSsrZsl74w1LQ=.6fdb0021-406f-4c9b-b5e4-e92d1a233c0b () github ! com
[Download RAW message or body]

> Previously, a new key combination involving the option key was added to Aqua LAF \
> for JTextAreas. In doing so, some code was removed that created this regression. \
> The regression caused the right option key on Mac OS to incorrectly show another \
> KeyPressed event instead of a KeyReleased event when pressing and releasing the \
> key. Additionally, the location of the key was 'standard' instead of 'right'. \
> Adding back the key mask and its following code resolves the issue and doesn't \
> cause any other CI tests to fail. 
> The headful test included displays the key events as they're pressed. After the \
> changes, the test correctly shows the right option key's KeyPressed and KeyReleased \
> events and shows the location as 'right'.

Damon Nguyen has updated the pull request incrementally with one additional commit \
since the last revision:

  Modified test for easier use

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15432/files
  - new: https://git.openjdk.org/jdk/pull/15432/files/d1b3ae5e..0aa8d4a5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15432&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15432&range=03-04

  Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/15432.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15432/head:pull/15432

PR: https://git.openjdk.org/jdk/pull/15432


[prev in list] [next in list] [prev in thread] [next in thread]