[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v2]
From:       ScientificWare <duke () openjdk ! org>
Date:       2023-08-30 14:20:41
Message-ID: Wj6c5Ab6IuAU8ZjA_-lJgLhk0FBUcQGW64Mu60XuvFA=.452f04fe-6dfd-498a-aac7-7810740d28cc () github ! com
[Download RAW message or body]

> This is referenced in Java Bug Database as
> - [JDK-8314731 : Adds support for the alt attribute in the image type input HTML \
> tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731) 
> This is tracked in JBS as
> - [JDK-8314731 : Add support for the alt attribute in the image type input HTML \
> tag](https://bugs.openjdk.java.net/browse/JDK-8314731) 
> According [HTML 3.2 \
> specification](https://www.w3.org/TR/2018/SPSD-html32-20180315/#input) 
> `alt` is not an attribute of the `input` element.
> 
> According [HTML 4.01 \
> specifications](https://www.w3.org/TR/html4/interact/forms.html#h-17.4) :  
> > ... For accessibility reasons, authors should provide [alternate \
> > text](https://www.w3.org/TR/html4/struct/objects.html#alternate-text) for the \
> > image via the [alt](https://www.w3.org/TR/html4/struct/objects.html#adef-alt) \
> > attribute. ...
> 
> This feature is not implemented in `FormView.java`.
> 
>  ️  ~~This also affects the HTML 32 DTD~~
> 
> ![Screenshot_20230817_025316](https://github.com/openjdk/jdk/assets/19194678/8e580574-d842-4a65-884b-26e33cd12138)
>  
> Left before the patch and right after the patch.
> 
> 
> import java.awt.BorderLayout;
> import java.awt.Dimension;
> import javax.swing.JEditorPane;
> import javax.swing.JFrame;
> import javax.swing.JScrollPane;
> import javax.swing.SwingUtilities;
> import javax.swing.text.Document;
> import javax.swing.text.html.HTMLEditorKit;
> import javax.swing.text.html.StyleSheet;
> 
> public class HTMLAddsSupportAltInputTag {
> public static void main(String[] args) {
> new HTMLAddsSupportAltInputTag();
> }
> 
> public HTMLAddsSupportAltInputTag() {
> SwingUtilities.invokeLater(new Runnable(){
> public void run(){
> JEditorPane jEditorPane = new JEditorPane();
> jEditorPane.setEditable(false);
> JScrollPane scrollPane = new JScrollPane(jEditorPane);
> HTMLEditorKit kit = new HTMLEditorKit();
> jEditorPane.setEditorKit(kit);
> StyleSheet styleSheet = kit.getStyleSheet();
> styleSheet.addRule("""
> body {
> color: #000;
> font-family:times;
> margin: 4px;
> }
> """);
> String htmlString = """
> <html>
> <body>
> <input type=image name=point src="file:oracle_logo_50x50.jpg" alt="Logo Oracle \
> JPG"> <p>
> <input type=image name=point src="file:none_oracle_logo_50x50.jpg" alt="Logo Oracle \
> JPG"> <p>
> <input type=image name=point src...

ScientificWare has updated the pull request incrementally with one additional commit \
since the last revision:

  Update src/java.desktop/share/classes/javax/swing/text/html/FormView.java
  
  FormView.java : Remove a redundant space.
  
  Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15319/files
  - new: https://git.openjdk.org/jdk/pull/15319/files/e6308e01..0e08107b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15319&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15319&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/15319.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15319/head:pull/15319

PR: https://git.openjdk.org/jdk/pull/15319


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic