[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8312165: Fix typos in java.desktop
From:       Andrey Turbanov <aturbanov () openjdk ! org>
Date:       2023-08-30 8:12:14
Message-ID: XVuy-mzYaAyVRj93iF-kGLOrEuCey8bpC-bUQXm0NxI=.3d522932-1ac4-4df5-ac0e-7c9fc5478136 () github ! com
[Download RAW message or body]

On Tue, 29 Aug 2023 18:16:35 GMT, Alexey Ivanov <aivanov@openjdk.org> wrote:

> > Found many typos in java.desktop by IDEA's inspection `Proofreading | Typo`
> 
> src/java.desktop/share/classes/javax/swing/plaf/nimbus/InnerShadowEffect.java line \
> 48: 
> > 46:      * painted. OVER means the result of apply effect should be painted over \
> >                 the src image.
> > 47:      *
> > 48:      * @return The effect type
> 
> Should we replace this copied javadoc with `{@inheritDoc}`? The text from \
> `Effect.getEffectType` isn't modified at all. This looks the correct fix — \
> eliminate doc duplication.

Ok, applied

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14847#discussion_r1309864804


[prev in list] [next in list] [prev in thread] [next in thread]