[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8258970: Disabled JPasswordField foreground color is wrong with GTK LAF [v2]
From:       Damon Nguyen <dnguyen () openjdk ! org>
Date:       2023-08-29 22:28:09
Message-ID: F_MeqtNV71FuyIIci2g2IveU50xP8SWfnt1qSpDY2e4=.de410393-449b-419f-b597-deb46da601fb () github ! com
[Download RAW message or body]

On Mon, 21 Aug 2023 10:42:07 GMT, Abhishek Kumar <abhiscxk@openjdk.org> wrote:

> > Disabled JPasswordField foreground color was not grayed out in GTK LAF.
> > 
> > The foreground color in disabled state was close to black color (RGB 0,0,0) for \
> > password field which is not differentiable from enabled state foreground color. 
> > To fix for this problem, the widget type is changed to `TEXT_AREA `for disable \
> > password field which returns the foreground color as gray. Checked with Oracle \
> > linux as well and fix worked fine. 
> > An automated test case has been added and checked in CI, link is added in JBS. \
> > Test mentioned in JBS also works fine with the fix.
> 
> Abhishek Kumar has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Fix extended for TextField, FormattedTextField, Spinner

Looks good to me on Ubuntu now.

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/15263#pullrequestreview-1601387705


[prev in list] [next in list] [prev in thread] [next in thread]