[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: JDK-8313252: Java_sun_awt_windows_ThemeReader_paintBackground release resources in early re
From:       Christoph Langer <clanger () openjdk ! org>
Date:       2023-07-31 7:24:45
Message-ID: OoazlfHkZ3nlaJ86apXYzNFVppk57ACj-S2PqrK7Qtk=.d217551d-7cd5-4235-8ed1-5e99d68a5715 () github ! com
[Download RAW message or body]

On Fri, 28 Jul 2023 07:52:14 GMT, Matthias Baesken <mbaesken@openjdk.org> wrote:

> In file ThemeReader.cpp functionJava_sun_awt_windows_ThemeReader_paintBackground
> we create DCs and release them at the end, but seems we miss it in early returns.
> 
> While looking at the code, I noticed that CreateCompatibleDC can return NULL in \
> case of error/failure, but we ignore this case; see  \
> https://learn.microsoft.com/en-us/windows/win32/api/wingdi/nf-wingdi-createcompatibledc \
> . Should we better handle it or is it not really occurring in practise ?

Marked as reviewed by clanger (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/15064#pullrequestreview-1554108843


[prev in list] [next in list] [prev in thread] [next in thread]