[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v7]
From:       Abhishek Kumar <abhiscxk () openjdk ! org>
Date:       2023-07-31 3:26:50
Message-ID: xY6XJYaNrrdqavZ4fRJpXRx-CQKE-Wu-pUUvz0dMh8U=.aabc6b6d-b243-48bc-9676-5f3265abda91 () github ! com
[Download RAW message or body]

On Tue, 25 Jul 2023 11:59:20 GMT, Abhishek Kumar <abhiscxk@openjdk.org> wrote:

> > The issue exist only for non-editable combobox and the root cause is accessible \
> > object is not created due to incorrect index returned from component class which \
> > results in no a11y API invoked. 
> > Proposed solution is to return the correct accessible child from \
> > getAccessibleChild method which is AquaComboBoxButton (arrowButton) instance and \
> > that results in invoking the a11y APIs to return the current selected item in \
> > combobox.  
> > Further when the application comes up first time the accessible name is not set \
> > for current displayed item in JCombobox that is handled in AquaComboBoxButton \
> > which will take care for the current selected item as well as if user modifies \
> > the selection by drop-down list. 
> > CI link is posted in JBS.
> 
> Abhishek Kumar has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Revert BasicComboBoxUI fix and update review comment

@aivanov-jdk Updated the suggested changes. Do you have any other suggestions?

@mrserb Checked with JAWS on windows and updated accordingly. 
Please have a look.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14497#issuecomment-1657442360
PR Comment: https://git.openjdk.org/jdk/pull/14497#issuecomment-1657443556


[prev in list] [next in list] [prev in thread] [next in thread]