[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8301606: JFileChooser file chooser details view "size" label cut off in Metal Look&Feel [v7
From:       Alexey Ivanov <aivanov () openjdk ! org>
Date:       2023-07-28 15:40:56
Message-ID: 8NygNhBODhONgiQmGa8D42USK750P3vjfELM93p_rW8=.e7727698-b3dd-461e-97ca-cd20ab743cd6 () github ! com
[Download RAW message or body]

On Fri, 28 Jul 2023 15:26:11 GMT, Tejesh R <tr@openjdk.org> wrote:

> > "size" label which is _RIGHT_ aligned is cut off on header cell. The issue is not \
> > only w.r.t to `JFileChooser` rather it is part of `JTable`. The root caused is \
> > found to be that in metal L&F the border insets is set to `(2,2,2,0)` meaning the \
> > right most inset value is 0. Hence when UIScaling increases the issue will be \
> > visible clearly. The fix addresses the issue by setting the right `inset` to 2 \
> > similar to other `inset` values. (Though the reason for setting it to 0 is \
> > unclear since it was initial load).  CI testing shows green.
> > After the fix at 225% scaling:
> > ![image](https://github.com/openjdk/jdk/assets/94159358/f3e5a88a-1710-4ee0-84aa-338bc93010b2)
> > 
> 
> Tejesh R has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Review fix

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/14464#pullrequestreview-1552383300


[prev in list] [next in list] [prev in thread] [next in thread]