[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v
From:       Alexey Ivanov <aivanov () openjdk ! org>
Date:       2023-07-28 12:32:55
Message-ID: PvOOBAU1z1Ov4zKL7qJ6TsxuE-PCdoOleS85AZbh1wc=.b5963cbc-55b0-4657-bca9-ada3391ffe39 () github ! com
[Download RAW message or body]

On Thu, 27 Jul 2023 16:32:35 GMT, Alexey Ivanov <aivanov@openjdk.org> wrote:

> > > > I think this patch would also address \
> > > > https://bugs.openjdk.org/browse/JDK-7116070
> > > 
> > > It didn't, the test case still produces truncated names.
> > > 
> > > Although, the mixer name used for recording in the stand-alone test attached to \
> > > [JDK-8301846](https://bugs.openjdk.org/browse/JDK-8301846) is not truncated any \
> > > more.
> > 
> > Partially fixing, with the fix this was the output on my machine :
> > _mixer 0: >>Port Speakers (Realtek(R) Audio)<<
> > mixer 1: >>Port Microphone Array (Realtek(R) Au<<
> > mixer 2: >>Primary Sound Driver<<
> > mixer 3: >>Speakers (Realtek(R) Audio)<<
> > mixer 4: >>Primary Sound Capture Driver<<
> > mixer 5: >>Microphone Array (Realtek(R) Audio)<<_
> > 
> > Without fix would be like this:  _mixer 5: >>Microphone Array (Realtek(R) Au<<_
> 
> > > I think this patch would also address \
> > > https://bugs.openjdk.org/browse/JDK-7116070
> > 
> > It didn't, the test case still produces truncated names.
> > 
> > Although, the mixer name used for recording in the stand-alone test attached to \
> > [JDK-8301846](https://bugs.openjdk.org/browse/JDK-8301846) is not truncated any \
> > more.
> 
> The latest code still produces truncated strings for the test case in \
> ~~JDK-8301846~~ JDK-7116070. Are there any other enumerations which need to be \
> wrapped into COM initialisation?

> @aivanov-jdk, thank you very much for your review, JDK-8301846 helps for fixing \
> _Primary Sound Driver_ recording device name truncation issue.

I referred to JDK-7116070. The root cause of that problem seems to be same as this \
one. While you and the reviewers have all the context, I suggest looking into \
JDK-7116070 in more details to understand why there are still devices, or rather \
*ports*, with truncated descriptions.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14898#issuecomment-1655609298


[prev in list] [next in list] [prev in thread] [next in thread]