[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8166900: If you wrap a JTable in a JLayer, the cursor is moved to the last row of table by 
From:       Abhishek Kumar <abhiscxk () openjdk ! org>
Date:       2023-06-30 10:10:55
Message-ID: hMA2IiT_Zd8_dSWY9rVhvIXKvJn3aIMbBZ5-fe64c8M=.4b8e6369-2724-4b21-b0f0-01c699465e52 () github ! com
[Download RAW message or body]

On Fri, 23 Jun 2023 03:14:21 GMT, Prasanta Sadhukhan <psadhukhan@openjdk.org> wrote:

> > If a JTable is wrapped in JLayer and first row is selected and VK_PAGE_DOWN is \
> > pressed, the last row of the table is selected instead of the next row after \
> > current viewport. This is because table.getParent.getSize() returns the whole \
> > table size  whereas it should be the JViewport which size should be used to \
> > calculate the "delta" to be used to scroll the table and select the row and \
> > "SwingUtilities.getUnwrappedParent(table)" gets the viewport. 
> > Tested against SwingSet2 too where it worked too.
> 
> Prasanta Sadhukhan has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Formatting

Fix verified.

-------------

Marked as reviewed by abhiscxk (Committer).

PR Review: https://git.openjdk.org/jdk/pull/14614#pullrequestreview-1506920908


[prev in list] [next in list] [prev in thread] [next in thread]