[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Withdrawn: 8311043: Remove trailing blank lines in source files
From:       Leo Korinth <lkorinth () openjdk ! org>
Date:       2023-06-29 16:55:06
Message-ID: Hsf1WhdMKL5I-3HmOkCZQJWI3MPIHPnFUpo_oMkZj6I=.1ca1f233-3eb8-4d1e-ae3e-eb19729dc1c9 () github ! com
[Download RAW message or body]

On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth <lkorinth@openjdk.org> wrote:

> Remove trailing "blank" lines in source files.
> 
> I like to use global-whitespace-cleanup-mode, but I can not use it if the files are \
> "dirty" to begin with. This fix will make more files "clean". I also considered \
> adding a check for this in jcheck for Skara, however it seems jcheck code handling \
> hunks does not track end-of-files. Thus I will only clean the files. 
> The fix removes trailing lines matching ^[[:space:]]*$ in
> 
> - *.java
> - *.cpp
> - *.hpp
> - *.c
> - *.h 
> 
> I have applied the following bash script to each file:
> 
> file="$1"
> 
> while [[ $(tail -n 1 "$file") =~ ^[[:space:]]*$ ]]; do
> truncate -s -1 "$file"
> done
> 
> `git diff --ignore-space-change --ignore-blank-lines  master` displays no changes
> `git diff --ignore-blank-lines  master` displays one change

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/14698


[prev in list] [next in list] [prev in thread] [next in thread]