[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8305667: Some fonts installed in user directory are not detected on Windows [v2]
From:       Phil Race <prr () openjdk ! org>
Date:       2023-06-27 20:03:12
Message-ID: Q7tDZ9fcvlqTSzuoxq0BJKSAOOUDV6YCBAZ8lhWH_gk=.03b2295e-b12a-490f-9f5f-f98116641814 () github ! com
[Download RAW message or body]

On Tue, 13 Jun 2023 14:10:11 GMT, Nikita Gubarkov <ngubarkov@openjdk.org> wrote:

> > `data` array has size of `MAX_BUFFER` like `wname`, but it has a char type, so \
> > its size is twice smaller than actual path limit, because paths returned by \
> > `RegEnumValueW` use wide chars. We need to double this limit.
> 
> Nikita Gubarkov has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Use malloc instead of fixed size buffers.

Marked as reviewed by prr (Reviewer).

Automated testing looks good.

-------------

PR Review: https://git.openjdk.org/jdk/pull/13359#pullrequestreview-1501754000
PR Comment: https://git.openjdk.org/jdk/pull/13359#issuecomment-1610133182


[prev in list] [next in list] [prev in thread] [next in thread]