[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8308286 Fix clang warnings in linux code [v3]
From:       Weijun Wang <weijun () openjdk ! org>
Date:       2023-05-31 13:55:57
Message-ID: XCV9wPHhv83rnla_Y8LoBYJ9EdcQfuAlClsvp01vHdg=.d8982ce2-253e-4ba5-93f5-ca12c489c38b () github ! com
[Download RAW message or body]

On Wed, 31 May 2023 13:37:06 GMT, Artem Semenov <asemenov@openjdk.org> wrote:

> > When using the clang compiler to build OpenJDk on Linux, we encounter various \
> > "warnings as errors". They can be fixed with small changes.
> 
> Artem Semenov has updated the pull request incrementally with one additional commit \
> since the last revision: 
> update

src/java.security.jgss/share/native/libj2gss/gssapi.h line 47:

> 45: 
> 46: // Condition was copied from
> 47: // Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/gssapi/gssapi.h
> 

In the current version of the file above, it's written as

#if defined(__APPLE__) && (defined(__ppc__) ||...

Is it better?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14033#discussion_r1211757380


[prev in list] [next in list] [prev in thread] [next in thread]