[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8307325: Verify the focus owner when non focused windows requesting focus [v2]
From:       Alisen Chung <achung () openjdk ! org>
Date:       2023-05-30 19:16:01
Message-ID: uLNiiXCXhoB8PydKtXNhbUtxwToQKYPBXp99DzSa1qA=.b4d4b82d-b30d-44a7-a9d6-eb052e59fdd2 () github ! com
[Download RAW message or body]

On Tue, 16 May 2023 05:04:51 GMT, Ravi Gupta <duke@openjdk.org> wrote:

> > Write a test Check, when the top level Window is not the focused Window \
> > requesting for focus and becoming the Focus Owner for any Component in that \
> > Window checking the following 
> > 1.The Component is the Focus Owner and the Window becomes the focused Window If \
> > the platform supports cross requesting focus across Windows.
> > 2.The request is remembered and  be granted when the Window is later focused If \
> > the platform does not support requesting focus across Windows.
> > 
> > Testing:
> > Tested using Mach5(20 times per platform) in macos,linux and windows and got all \
> > pass.
> 
> Ravi Gupta has updated the pull request incrementally with one additional commit \
> since the last revision: 
> 8307325: Review comments fixed

test/jdk/java/awt/Focus/CrossFocusRequestTest/CrossFocusRequestTest.java line 111:

> 109: 
> 110:     private static void initializeGUI() {
> 111:         frame1 = new Frame("Test Frame1");

Should these frames be named something specific to the test?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13790#discussion_r1210715878


[prev in list] [next in list] [prev in thread] [next in thread]