[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Integrated: 8289547 : Update javax/swing/Popup/TaskbarPositionTest.java
From:       Renjith Kannath Pariyangad <duke () openjdk ! org>
Date:       2023-05-29 12:55:08
Message-ID: bnzq18SYoGzVhj1OU3jjxNqH8aet2T5hPzgeYZ_y1vg=.f9fa7c4f-bf67-48ca-9506-d9fead980a2b () github ! com
[Download RAW message or body]

On Fri, 21 Apr 2023 12:58:58 GMT, Renjith Kannath Pariyangad <duke@openjdk.org> \
wrote:

> Hi Reviewers,
> Noticed this test case not verifying all the cases which is intended. Modified it \
> for improving the coverage for 3 type of popups (menu, context menu and combobox). 
> Evaluating conditions:
> 1. Not enough space for showing popup downwards(default layout), it should show \
> upwards 2. Window starts from negative position, Popup should show on visible area
> 
> For achieving this following areas are modified
> - Updated isPopupOnScreen by adding Additional checks (like the position of \
>                 combobox popup is always verified)
> - Menu creation made as function and reused for all menu creation.
> - Updated ComboPopupCheckListener class and modified its \
> popupMenuWillBecomeInvisible function. Made it as generic and it is capable to \
>                 evaluate any combo box's position if this class set as its \
>                 listener.
> - This test case is not intended for multi monitor setup so added a check for \
>                 identifying monitor, else error out.
> - Updated CTRL_MASK to CTRL_DOWN_MASK for removing depreciation warnings and \
> removed some other warnings. 
> Please review this
> 
> Regards,
> Renjith.

This pull request has now been integrated.

Changeset: d73fc70e
Author:    Renjith <renjith.kannath.pariyangad@oracle.com>
Committer: Alexey Ivanov <aivanov@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/d73fc70ea272be6bf4f1c82608c73ff0a8f6032d
                
Stats:     246 lines in 1 file changed: 132 ins; 54 del; 60 mod

8289547: Update javax/swing/Popup/TaskbarPositionTest.java

Reviewed-by: aivanov, dmarkov, honkar

-------------

PR: https://git.openjdk.org/jdk/pull/13578


[prev in list] [next in list] [prev in thread] [next in thread]