[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code [v2]
From:       Kim Barrett <kbarrett () openjdk ! org>
Date:       2023-05-25 9:13:13
Message-ID: OgFFt12b4OPE5wWJUV2wmjw9H2g4wOW1wbSXvgW4i9A=.ba8ed826-e5c8-478f-a949-518b37a268e7 () github ! com
[Download RAW message or body]

On Thu, 25 May 2023 07:16:29 GMT, JoKern65 <duke@openjdk.org> wrote:

> > That's not what I see in this PR, and not what I see in the repository after the \
> > integration.  Where are you seeing that?  (If in your local repository, maybe you \
> > forgot a push to the PR?)
> 
> I checked it directly in repository
> [https://github.com/openjdk/jdk/blob/master/src/hotspot/os/aix/os_aix.cpp](https://github.com/openjdk/jdk/blob/master/src/hotspot/os/aix/os_aix.cpp)
>  And there I see the desired
> `struct shmid_ds shm_buf{};`

Weird! I see:
https://github.com/openjdk/jdk/blob/master/src/hotspot/os/aix/os_aix.cpp#L467
(permalink:)
`https://github.com/openjdk/jdk/blob/d87713440a1ddb830e87171b009efe9507e644cb/src/hotspot/os/aix/os_aix.cpp#L467`
 https://github.com/openjdk/jdk/blob/d87713440a1ddb830e87171b009efe9507e644cb/src/hotspot/os/aix/os_aix.cpp#L467


      struct shmid_ds shm_buf = { };

(above line was cut-and-pasted)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13953#discussion_r1205226537


[prev in list] [next in list] [prev in thread] [next in thread]