[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    RFR: 8307145: windowsaccessbridge.dll is missing 4 critical methods in its C API
From:       Julian Waters <jwaters () openjdk ! org>
Date:       2023-04-29 19:46:58
Message-ID: 3n_rUEMgKOYJOL4dt9nR_cm__hPAWcLEGf24ManahQ4=.5a72810c-997d-4b38-a021-d5886a26bfbd () github ! com
[Download RAW message or body]

In windowsaccessbridge(-64).dll the following methods are exported in a def file to C \
API which in turn call their real implementation, which are instance methods of the \
class WinAccessBridge:

addJavaEventNotification
removeJavaEventNotification
addAccessibilityEventNotification
removeAccessibilityEventNotification


However, they are nowhere to be seen in the actual C interface, in \
AccessBridgeWindowsEntryPoints.cpp. Your guess is as good as mine as to how on earth \
MSVC is still capable of compiling and linking this without any errors whatsoever, \
but in any case, this is a severe oversight and should be properly defined in the C \
API lest this happy accident within MSVC is fixed by Microsoft in the future

-------------

Commit messages:
 - Declare missing API in header as well
 - windowsaccessbridge.dll is missing 4 critical methods in its C API

Changes: https://git.openjdk.org/jdk/pull/13734/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13734&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8307145
  Stats: 29 lines in 2 files changed: 29 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/13734.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13734/head:pull/13734

PR: https://git.openjdk.org/jdk/pull/13734


[prev in list] [next in list] [prev in thread] [next in thread]