[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v5]
From:       Naoto Sato <naoto () openjdk ! org>
Date:       2023-03-31 22:48:29
Message-ID: G-JuA4B7q1ygFjywx4FOwGfJX2Ud-Jf4BwgrzPykvXg=.61ddf6ba-5a7d-45a2-87aa-4613ec3dfb3b () github ! com
[Download RAW message or body]

On Fri, 17 Mar 2023 22:27:48 GMT, Justin Lu <jlu@openjdk.org> wrote:

> > This PR converts Unicode sequences to UTF-8 native in .properties file. \
> > (Excluding the Unicode space and tab sequence). The conversion was done using \
> > native2ascii. 
> > In addition, the build logic is adjusted to support reading in the .properties \
> > files as UTF-8 during the conversion from .properties file to .java \
> > ListResourceBundle file.
> 
> Justin Lu has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Close streams when finished loading into props

Hmm, I just wonder why they are sticking to ISO-8859-1 as the default. I know \
j.u.Properties defaults to 8859-1, but PropertyResourceBundle, which is their primary \
use defaults to UTF-8 since JDK9 (https://openjdk.org/jeps/226)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12726#issuecomment-1492682703


[prev in list] [next in list] [prev in thread] [next in thread]