[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8301616: Drag & maximize to another monitor places window incorrectly (Windows) [v2]
From:       Nikita Gubarkov <duke () openjdk ! org>
Date:       2023-03-30 15:51:25
Message-ID: mrCe-KN1BP35MHb64JemvC2jRfThPvgQ0Mtc9XfvFaI=.243ac447-e45d-421e-9552-34b64aa54b55 () github ! com
[Download RAW message or body]

On Thu, 23 Mar 2023 22:53:43 GMT, Sergey Bylokhov <serb@openjdk.org> wrote:

> > Nikita Gubarkov has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > 8301616: Drag & maximize to another monitor places window incorrectly (Windows)
> 
> src/java.desktop/windows/native/libawt/windows/awt_Window.cpp line 374:
> 
> > 372:     WINDOWPOS * wp = (WINDOWPOS *)windowPos;
> > 373: 
> > 374:     // There's no good way to detect partial maximization (e.g. Aero Snap),
> 
> Does the bug affect all windows, or only frames/dialog? Can we move this code to \
> the AwtFrame#WmWindowPosChanging?

I believe it should only affect frames and dialogs, but I don't understand, why it \
wasn't done for `CheckWindowDPIChange` in the first place, AFAIU this hack is only \
relevant for frames and dialogs as well. I can move this code into AwtFrame, but then \
I'd need to loosen visibility of `prevScaleRec` and `m_screenNum`, I personally don't \
think it worth it. What do you think?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12367#discussion_r1153462844


[prev in list] [next in list] [prev in thread] [next in thread]