[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8304718: GetIntArrayElements should not be passed JNI_FALSE [v3]
From:       Sergey Bylokhov <serb () openjdk ! org>
Date:       2023-03-27 5:09:31
Message-ID: a2v_4W6m6m80maDKkxfjfnvEEK_QKqRZVrt2xHCN-iI=.f7c86a2c-b8bf-4ea0-8000-3f23238184ab () github ! com
[Download RAW message or body]

On Thu, 23 Mar 2023 22:02:32 GMT, Julian Waters <jwaters@openjdk.org> wrote:

> > AWT passes JNI_FALSE to the JVM to avoid a copy, which is not correct since JNI \
> > has absolutely no control over whether a copy is made or not. The parameter in \
> > question is a pointer to a jboolean that the JVM sets to indicate whether it made \
> > a copy or not, which should be passed nullptr because we don't bother about the \
> > copy status of the jint
> 
> Julian Waters has updated the pull request incrementally with one additional commit \
> since the last revision: 
> LWCToolkit.m

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/13140#pullrequestreview-1358332444


[prev in list] [next in list] [prev in thread] [next in thread]