[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java
From:       Tejesh R <tr () openjdk ! org>
Date:       2023-02-28 4:29:04
Message-ID: 7VeayFwnLsYPstYhqTO1qWrglY18-tQkk1eb9bDg-3I=.677a67a1-6308-482e-b634-15edd257b2a2 () github ! com
[Download RAW message or body]

On Thu, 16 Feb 2023 14:38:21 GMT, Alexey Ivanov <aivanov@openjdk.org> wrote:

> The test has become unstable recently, there were quite a few failures, on Windows \
> mostly. I was lucky enough to find a host where the test failed consistently. 
> I call `System.gc()` directly as suggested in comments to the bug. I used \
> `PhantomReference` instead of `WeakReference`. 
> Now the test calls `System.gc()` in a loop and waits for the reference to be \
> enqueued. In majority of cases, the test exits the loop at the second attempt.

Looks good to me.

-------------

Marked as reviewed by tr (Committer).

PR: https://git.openjdk.org/jdk/pull/12594


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic