[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8302173: Button border overlaps with button icon on macOS system LaF [v5]
From:       Prasanta Sadhukhan <psadhukhan () openjdk ! org>
Date:       2023-02-23 3:25:05
Message-ID: tuTG4zg7ZpNZU5akeLbPY09DuqAo3DMEPwF7F-RiKS4=.1a1950e2-5808-49af-a79a-ea0348bec5b7 () github ! com
[Download RAW message or body]

On Wed, 22 Feb 2023 17:52:01 GMT, Damon Nguyen <dnguyen@openjdk.org> wrote:

> > Previous fix to HTML in AquaButtonUI fixed spacing issue for HTML images in a \
> > JButton in Aqua L&F. The new issue comes from having text inside the HTML as the \
> > button's text. If an icon is used, this icon exceeds the bounds of the button and \
> > overlaps the border. 
> > Added additional logic to check if HTML contains an img. If so, apply the \
> > previous fix. Otherwise, the original implementation for Aqua's JButton HTML \
> > layout works correctly, so use this behavior. 
> > Added a test based on the provided test in the bug report. Automated the test \
> > using a BufferedImage and changed the icon color to RED. Tested with multiple \
> > runs on Aqua L&F, and the test passes with the update where it fails without the \
> > update.
> 
> Damon Nguyen has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Add reusable icon var. Update comment.

ok looks fine

-------------

Marked as reviewed by psadhukhan (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12520


[prev in list] [next in list] [prev in thread] [next in thread]