[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8301443: Clean broken comments from Windows code
From:       Julian Waters <jwaters () openjdk ! org>
Date:       2023-01-31 7:01:57
Message-ID: L7MKQlWUBi4ab22ZD56GLRhdPeEUGVcSTFRkz3cRKZc=.ed8edde6-1e26-47fe-a4e3-084ba5806445 () github ! com
[Download RAW message or body]

On Tue, 31 Jan 2023 06:28:21 GMT, Julian Waters <jwaters@openjdk.org> wrote:

> Several comments are technically broken in Windows code, this change cleans up the \
> broken comments that managed to slip past reviewers during Integration

@wangweij Sorry for the abrupt tag, but would the sspi.cpp change be fine with you? \
It seems like the comment is intended to signal a newline so the compile command's \
second half on the next line is read properly, but Visual C++ will simply interpret \
it as the object file \.o, which isn't correct, but I don't quite know the context \
behind that comment so I thought I'd ask first (On top of the fact that cmd doesn't \
allow newline formatted commands at all)

-------------

PR: https://git.openjdk.org/jdk/pull/12305


[prev in list] [next in list] [prev in thread] [next in thread]