[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-2d-dev
Subject:    Re: RFR: 8301342: Prefer ArrayList to LinkedList in LayoutComparator
From:       Phil Race <prr () openjdk ! org>
Date:       2023-01-30 22:56:55
Message-ID: 8mxsL5sZVj66_mFw2EQZSZcJwKmr3vWqa58NyBXGObI=.b9099660-a7e3-4d41-85dd-be459480392b () github ! com
[Download RAW message or body]

On Sat, 28 Jan 2023 14:54:38 GMT, Andrey Turbanov <aturbanov@openjdk.org> wrote:

> There is only add/iterator calls on this list. No removes from the head or \
> something like this. Not sure why LinkedList was used, but ArrayList should be \
> preferred as more efficient and widely used (more chances for JIT) collection

I expect some testing to be done before it is pushed.

This looks safe but  I rather doubt anyone will be able to measure or ever see any \
performance benefit. I suggest some manual testing of focus traversal which seems to \
be the sole user of the containing class.

-------------

Marked as reviewed by prr (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12274


[prev in list] [next in list] [prev in thread] [next in thread]